Skip to content

Fix CI on main: Add window function examples in code #16102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Fix CI on main: Add window function examples in code #16102

merged 1 commit into from
May 19, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 19, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

  1. Add sql examples to source code to get CI clean again

Are these changes tested?

Are there any user-facing changes?

@alamb alamb mentioned this pull request May 19, 2025
Merged
@github-actions github-actions bot added documentation Improvements or additions to documentation functions Changes to functions implementation labels May 19, 2025
@alamb
Copy link
Contributor Author

alamb commented May 19, 2025

Thanks @adriangb

@Adez017
Copy link
Contributor

Adez017 commented May 19, 2025 •
edited
Loading

Very impressive @alamb , you got it correct wihtout any overhead . great work
have a look on #15832

@alamb alamb mentioned this pull request May 19, 2025
Merged
@alamb
Copy link
Contributor Author

alamb commented May 19, 2025

Very impressive @alamb , you got it correct wihtout any overhead . great work have a look on #15832

Thanks I will try and check out #15832 sometime -- I want to sit down and give it a thorough review but I am struggling to find enough contiguous time

@alamb
Copy link
Contributor Author

alamb commented May 19, 2025

Thank you for the quick review @andygrove -- merging this in to unblock CI (we have a pile of PRs waiting to merge)

@alamb alamb merged commit e3e7d50 into apache:main May 19, 2025
28 checks passed
@alamb alamb deleted the alamb/add_examples_in_code branch May 19, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation functions Changes to functions implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alamb @Adez017 @andygrove @adriangb